Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct 201 source config functionality #4976

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 29, 2022

resolves #3662

Description

Very in progress. But I got the source table level configs set and making it into the manifest. The source level configs don't work yet. That's because add_source_definitions only adds the configs to the table level so the source level gets ignore for now.

What this does:

  1. Add config definitions to SourceConfigs
  2. Add functionality for configs to end up in the manifest when assigned at the source table level in a yaml file
  3. Tests that are expected to fail are marked as such in test_source_configs.py
  4. Some TODOs of where I'm thinking things might happen

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@cla-bot cla-bot bot added the cla:yes label Mar 29, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop closed this Apr 6, 2022
@emmyoop emmyoop closed this Apr 6, 2022
@emmyoop emmyoop deleted the ct-201-source-config-functionality branch April 6, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant